Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Inclusive Gateway Errors #18

Merged
merged 3 commits into from
Sep 19, 2022
Merged

Handle Inclusive Gateway Errors #18

merged 3 commits into from
Sep 19, 2022

Conversation

philippfromme
Copy link
Collaborator

@philippfromme philippfromme commented Sep 12, 2022 •
edited
Loading

  • depend on bpmnlint-plugin-camunda-compat v0.12.0
  • adjust error message
  • point to properties panel entry if condition is missing

Requires camunda/bpmnlint-plugin-camunda-compat#44
Related to camunda/camunda-modeler#3083

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Sep 12, 2022
@philippfromme philippfromme changed the title feat: adjust error messages for inclusive gateway errors Handle Inclusive Gateway Errors Sep 12, 2022
This was referenced Sep 12, 2022
Closed
Merged
barmac
barmac reviewed Sep 12, 2022
View reviewed changes
@philippfromme philippfromme marked this pull request as ready for review September 12, 2022 14:39
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 12, 2022
@barmac
Copy link
Contributor

barmac commented Sep 12, 2022

How do I test this?

image

@barmac
Copy link
Contributor

barmac commented Sep 12, 2022

The screenshot with missing annotations is from npm start script.

@barmac
Copy link
Contributor

barmac commented Sep 12, 2022

As npm ci failed on my machine, I run npm i and squashed the changes in package-lock.json.

@philippfromme
test: improve npm start test
02235af 
* show error messages
* show properties panel
@philippfromme
Copy link
Collaborator Author

philippfromme commented Sep 16, 2022 •
edited
Loading

@barmac I've updated the npm start test and made the following changes:

  • hook up linter
  • show error messages in dummy error panel
  • include properties panel
  • be able to set execution platform version

image

nikku
nikku approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@philippfromme philippfromme merged commit fc4c4f6 into main Sep 19, 2022
@philippfromme philippfromme deleted the inclusive-gateway branch September 19, 2022 11:00
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@barmac barmac Awaiting requested review from barmac

@pinussilvestrus pinussilvestrus Awaiting requested review from pinussilvestrus

Assignees

@philippfromme philippfromme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philippfromme @barmac @nikku